Skip to content

feat: codegen improvements for bevy 0.17 #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
makspll wants to merge 1 commit into
base: feat/bevy-0.17
Choose a base branch
from
Open

feat: codegen improvements for bevy 0.17 #503

makspll wants to merge 1 commit into from

Conversation

@makspll
Copy link
Owner

@makspll makspll commented Dec 17, 2025

Summary

The original PR makes it work, this one will make it pass tests (some of the new functions don't have bindings, so for example creating an entity from raw requires a custom binding atm)

@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 17, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/bindings/bevy_gltf_bms_bindings/src/lib.rs  90% smaller
  crates/bindings/bevy_light_bms_bindings/src/lib.rs  90% smaller
  crates/bindings/bevy_post_process_bms_bindings/src/lib.rs  89% smaller
  crates/bindings/bevy_core_pipeline_bms_bindings/src/lib.rs  89% smaller
  crates/bindings/bevy_gizmos_bms_bindings/src/lib.rs  89% smaller
  crates/bindings/bevy_animation_bms_bindings/src/lib.rs  88% smaller
  crates/bindings/bevy_pbr_bms_bindings/src/lib.rs  88% smaller
  crates/bindings/bevy_a11y_bms_bindings/src/lib.rs  88% smaller
  crates/bindings/bevy_picking_bms_bindings/src/lib.rs  87% smaller
  crates/bindings/bevy_time_bms_bindings/src/lib.rs  87% smaller
  crates/bindings/bevy_text_bms_bindings/src/lib.rs  87% smaller
  crates/bindings/bevy_scene_bms_bindings/src/lib.rs  87% smaller
  crates/bindings/bevy_ui_render_bms_bindings/src/lib.rs  86% smaller
  crates/bindings/bevy_asset_bms_bindings/src/lib.rs  86% smaller
  crates/bindings/bevy_input_focus_bms_bindings/src/lib.rs  85% smaller
  crates/bindings/bevy_ecs_bms_bindings/src/lib.rs  85% smaller
  crates/bindings/bevy_color_bms_bindings/src/lib.rs  85% smaller
  crates/bindings/bevy_math_bms_bindings/src/lib.rs  84% smaller
  codegen/src/modifying_file_loader.rs  62% smaller
  codegen/src/passes/find_reflect_types.rs  29% smaller
  codegen/src/passes/find_methods_and_fields.rs  27% smaller
  codegen/src/driver/mod.rs  21% smaller
  codegen/src/bin/main.rs  18% smaller
  codegen/src/context.rs  15% smaller
  codegen/src/driver/plugin.rs  15% smaller
  codegen/src/plugin.rs  7% smaller
  xtask/src/main.rs  1% smaller
  codegen/crates/crate_feature_graph/src/graph.rs  1% smaller
  codegen/src/candidate.rs  1% smaller
  codegen/Cargo.bootstrap.toml Unsupported file format
  codegen/Cargo.toml Unsupported file format
  codegen/crates/crate_feature_graph/bin/main.rs  0% smaller
  codegen/crates/crate_feature_graph/src/feature.rs  0% smaller
  codegen/src/args.rs  0% smaller
  codegen/src/bin/driver.rs  0% smaller
  codegen/src/callback.rs  0% smaller
  codegen/src/impls.rs  0% smaller
  codegen/src/lib.rs  0% smaller
  codegen/src/passes/cache_items.rs  0% smaller
  codegen/src/passes/cache_traits.rs  0% smaller
  codegen/src/passes/codegen.rs  0% smaller
  codegen/src/passes/find_trait_impls.rs  0% smaller
  codegen/src/passes/mod.rs  0% smaller
  codegen/src/ty_convert.rs  0% smaller
  codegen/templates/footer.tera Unsupported file format
  codegen/templates/header.tera Unsupported file format
  crates/bevy_mod_scripting_bindings/src/function/from.rs  0% smaller
  crates/bevy_mod_scripting_bindings/src/function/glue.rs  0% smaller
  crates/bevy_mod_scripting_bindings/src/function/mod.rs  0% smaller

@makspll makspll mentioned this pull request Dec 17, 2025
Open
3 tasks
@makspll makspll force-pushed the feat/bevy-0.17-part-2 branch from bfd2f21 to c77603b Compare December 17, 2025 23:10
@makspll makspll changed the base branch from main to feat/bevy-0.17 December 17, 2025 23:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025 •
edited
Loading

🐰 Bencher Report

Branchfeat/bevy-0.17-part-2
Testbedlinux-gha

🚨 6 Alerts

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
component/access RhaiLatency
microseconds (µs)		📈 plot
🚷 threshold
🚨 alert (🔔)		8.55 µs
(+34.19%)Baseline: 6.37 µs
8.45 µs
(101.17%)

component/get RhaiLatency
microseconds (µs)		📈 plot
🚷 threshold
🚨 alert (🔔)		7.33 µs
(+49.40%)Baseline: 4.90 µs
7.22 µs
(101.48%)

math/vec mat ops RhaiLatency
microseconds (µs)		📈 plot
🚷 threshold
🚨 alert (🔔)		9.59 µs
(+24.86%)Baseline: 7.68 µs
9.57 µs
(100.21%)

query/10 entities RhaiLatency
microseconds (µs)		📈 plot
🚷 threshold
🚨 alert (🔔)		27.83 µs
(+22.10%)Baseline: 22.79 µs
27.68 µs
(100.56%)

resource/access RhaiLatency
microseconds (µs)		📈 plot
🚷 threshold
🚨 alert (🔔)		8.25 µs
(+41.22%)Baseline: 5.84 µs
8.14 µs
(101.36%)

resource/get RhaiLatency
microseconds (µs)		📈 plot
🚷 threshold
🚨 alert (🔔)		7.04 µs
(+58.51%)Baseline: 4.44 µs
6.91 µs
(101.83%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold		5,527.50 ns
(+20.92%)Baseline: 4,571.08 ns
5,539.20 ns
(99.79%)
component/access Rhai📈 view plot
🚷 view threshold
🚨 view alert (🔔)		8,549.50 ns
(+34.19%)Baseline: 6,371.38 ns
8,450.62 ns
(101.17%)

component/get Lua📈 view plot
🚷 view threshold		3,261.20 ns
(+10.55%)Baseline: 2,949.89 ns
3,329.16 ns
(97.96%)
component/get Rhai📈 view plot
🚷 view threshold
🚨 view alert (🔔)		7,325.50 ns
(+49.40%)Baseline: 4,903.21 ns
7,218.32 ns
(101.48%)

conversions/Mut::from📈 view plot
🚷 view threshold		87.39 ns
(-15.99%)Baseline: 104.03 ns
120.86 ns
(72.31%)
conversions/Ref::from📈 view plot
🚷 view threshold		86.79 ns
(-13.58%)Baseline: 100.43 ns
114.29 ns
(75.94%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold		366.16 ns
(-6.10%)Baseline: 389.94 ns
449.54 ns
(81.45%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold		1,075.10 ns
(-10.00%)Baseline: 1,194.59 ns
1,360.89 ns
(79.00%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold		24.49 ns
(-14.68%)Baseline: 28.70 ns
33.32 ns
(73.49%)
conversions/Val::from_into📈 view plot
🚷 view threshold		295.96 ns
(-6.95%)Baseline: 318.05 ns
395.33 ns
(74.86%)
function/call 4 args Lua📈 view plot
🚷 view threshold		1,918.70 ns
(-10.84%)Baseline: 2,151.95 ns
2,430.64 ns
(78.94%)
function/call 4 args Rhai📈 view plot
🚷 view threshold		1,516.50 ns
(-3.47%)Baseline: 1,571.06 ns
1,729.51 ns
(87.68%)
function/call Lua📈 view plot
🚷 view threshold		380.41 ns
(-9.51%)Baseline: 420.38 ns
550.86 ns
(69.06%)
function/call Rhai📈 view plot
🚷 view threshold		510.17 ns
(+4.16%)Baseline: 489.78 ns
559.01 ns
(91.26%)
loading/empty Lua📈 view plot
🚷 view threshold		1,045,800.00 ns
(+0.93%)Baseline: 1,036,119.00 ns
1,391,267.21 ns
(75.17%)
loading/empty Rhai📈 view plot
🚷 view threshold		1,303,500.00 ns
(+0.76%)Baseline: 1,293,674.00 ns
1,857,772.83 ns
(70.16%)
math/vec mat ops Lua📈 view plot
🚷 view threshold		10,892.00 ns
(+24.99%)Baseline: 8,714.48 ns
10,930.55 ns
(99.65%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
🚨 view alert (🔔)		9,585.60 ns
(+24.86%)Baseline: 7,676.78 ns
9,565.47 ns
(100.21%)

query/10 entities Lua📈 view plot
🚷 view threshold		21,127.00 ns
(-13.33%)Baseline: 24,375.20 ns
27,864.28 ns
(75.82%)
query/10 entities Rhai📈 view plot
🚷 view threshold
🚨 view alert (🔔)		27,832.00 ns
(+22.10%)Baseline: 22,793.80 ns
27,676.65 ns
(100.56%)

query/100 entities Lua📈 view plot
🚷 view threshold		42,486.00 ns
(-9.86%)Baseline: 47,135.60 ns
52,345.83 ns
(81.16%)
query/100 entities Rhai📈 view plot
🚷 view threshold		40,979.00 ns
(+10.06%)Baseline: 37,232.00 ns
42,111.24 ns
(97.31%)
query/1000 entities Lua📈 view plot
🚷 view threshold		259,980.00 ns
(-15.45%)Baseline: 307,497.00 ns
377,256.95 ns
(68.91%)
query/1000 entities Rhai📈 view plot
🚷 view threshold		177,190.00 ns
(-6.75%)Baseline: 190,011.00 ns
224,226.40 ns
(79.02%)
reflection/10 Lua📈 view plot
🚷 view threshold		5,420.60 ns
(-12.39%)Baseline: 6,187.31 ns
6,954.97 ns
(77.94%)
reflection/10 Rhai📈 view plot
🚷 view threshold		14,661.00 ns
(-7.97%)Baseline: 15,931.20 ns
17,249.13 ns
(85.00%)
reflection/100 Lua📈 view plot
🚷 view threshold		45,545.00 ns
(-13.33%)Baseline: 52,550.70 ns
60,011.79 ns
(75.89%)
reflection/100 Rhai📈 view plot
🚷 view threshold		625,420.00 ns
(-20.80%)Baseline: 789,710.00 ns
967,462.59 ns
(64.65%)
resource/access Lua📈 view plot
🚷 view threshold		3,452.60 ns
(-13.74%)Baseline: 4,002.56 ns
4,581.78 ns
(75.36%)
resource/access Rhai📈 view plot
🚷 view threshold
🚨 view alert (🔔)		8,251.10 ns
(+41.22%)Baseline: 5,842.78 ns
8,140.63 ns
(101.36%)

resource/get Lua📈 view plot
🚷 view threshold		2,681.00 ns
(+5.01%)Baseline: 2,553.05 ns
2,862.70 ns
(93.65%)
resource/get Rhai📈 view plot
🚷 view threshold
🚨 view alert (🔔)		7,040.50 ns
(+58.51%)Baseline: 4,441.74 ns
6,913.79 ns
(101.83%)

🐰 View full continuous benchmarking report in Bencher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@makspll